Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with mode="r" vs mode="a" is fixed #466

Merged
merged 3 commits into from Jan 19, 2021
Merged

Conversation

edogrigqv2
Copy link
Contributor

No description provided.

@github-actions
Copy link

Locust summary

Git references

Initial: b4f0b9e
Terminal: 1d7966e

hub/url.py
Changes:
  • Name: Url
    Type: class
    Changed lines: 36
    Total lines: 36
    Changes:
    • Name: Url.parse
      Type: function
      Changed lines: 4
      Total lines: 4
      • Name: Url.__init__
        Type: function
        Changed lines: 25
        Total lines: 25
        • Name: Url.url
          Type: function
          Changed lines: 2
          Total lines: 2
        • Name: UrlProtocol
          Type: class
          Changed lines: 6
          Total lines: 6
          • Name: UrlType
            Type: class
            Changed lines: 4
            Total lines: 4
            hub/api/dataset.py
            Changes:
            • Name: Dataset
              Type: class
              Changed lines: 19
              Total lines: 1058
              Changes:
            hub/tests/test_url.py
            Changes:
            • Name: test_url
              Type: function
              Changed lines: 11
              Total lines: 11

              @codecov
              Copy link

              codecov bot commented Jan 19, 2021

              Codecov Report

              Merging #466 (54769a0) into master (05acc9e) will increase coverage by 0.09%.
              The diff coverage is 94.64%.

              Impacted file tree graph

              @@            Coverage Diff             @@
              ##           master     #466      +/-   ##
              ==========================================
              + Coverage   88.08%   88.18%   +0.09%     
              ==========================================
                Files          49       50       +1     
                Lines        3601     3655      +54     
              ==========================================
              + Hits         3172     3223      +51     
              - Misses        429      432       +3     
              Impacted Files Coverage Δ
              hub/api/dataset.py 89.74% <84.21%> (-0.20%) ⬇️
              hub/defaults.py 100.00% <100.00%> (ø)
              hub/url.py 100.00% <100.00%> (ø)

              Continue to review full report at Codecov.

              Legend - Click here to learn more
              Δ = absolute <relative> (impact), ø = not affected, ? = missing data
              Powered by Codecov. Last update 05acc9e...54769a0. Read the comment docs.

              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
              Labels
              None yet
              Projects
              None yet
              Development

              Successfully merging this pull request may close these issues.

              None yet

              2 participants