Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to get_dictionary #480

Merged
merged 1 commit into from Jan 23, 2021
Merged

Fixes to get_dictionary #480

merged 1 commit into from Jan 23, 2021

Conversation

AbhinavTuli
Copy link
Contributor

Fixes to get_dictionary and added unit tests for the same

@github-actions
Copy link

Locust summary

Git references

Initial: 0083358
Terminal: 9c46dd8

hub/api/dataset.py
Changes:
hub/api/datasetview.py
Changes:
hub/api/tests/test_dataset.py
Changes:

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #480 (9c46dd8) into master (66985dd) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
+ Coverage   88.29%   88.34%   +0.05%     
==========================================
  Files          52       52              
  Lines        3724     3724              
==========================================
+ Hits         3288     3290       +2     
+ Misses        436      434       -2     
Impacted Files Coverage Δ
hub/api/datasetview.py 92.05% <100.00%> (+0.66%) ⬆️
hub/api/dataset.py 90.31% <0.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66985dd...9c46dd8. Read the comment docs.

@AbhinavTuli AbhinavTuli merged commit f9800d5 into master Jan 23, 2021
@AbhinavTuli AbhinavTuli deleted the fixes/get_dictionary branch January 24, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant