Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering improvements #539

Merged
merged 6 commits into from Feb 15, 2021
Merged

Filtering improvements #539

merged 6 commits into from Feb 15, 2021

Conversation

AbhinavTuli
Copy link
Contributor

Changes dataset filtering API, support for functions as filters gives more flexibility. Also adds proper documentation for dataset filtering.

@github-actions
Copy link

github-actions bot commented Feb 8, 2021

Locust summary

Git references

Initial: 0128704
Terminal: 6986269

hub/api/dataset.py
Changes:
  • Name: Dataset
    Type: class
    Changed lines: 6
    Total lines: 1109
    Changes:
hub/api/datasetview.py
Changes:
hub/api/tests/test_dataset.py
Changes:

@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #539 (00c79a2) into master (0128704) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #539      +/-   ##
==========================================
- Coverage   88.46%   88.45%   -0.02%     
==========================================
  Files          52       52              
  Lines        3745     3724      -21     
==========================================
- Hits         3313     3294      -19     
+ Misses        432      430       -2     
Impacted Files Coverage Δ
hub/exceptions.py 100.00% <ø> (ø)
hub/api/dataset.py 89.08% <100.00%> (-0.16%) ⬇️
hub/api/datasetview.py 92.36% <100.00%> (+0.30%) ⬆️
hub/store/shape_detector.py 96.90% <0.00%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0128704...00c79a2. Read the comment docs.

Copy link
Contributor

@edogrigqv2 edogrigqv2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage needs to be improved.

@AbhinavTuli AbhinavTuli merged commit cc3abc2 into master Feb 15, 2021
@AbhinavTuli AbhinavTuli deleted the feature/filtering_improvements branch March 21, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants