-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced commit() with flush() in documentation. #604
Conversation
Codecov Report
@@ Coverage Diff @@
## master #604 +/- ##
=======================================
Coverage 89.25% 89.25%
=======================================
Files 53 53
Lines 3881 3882 +1
=======================================
+ Hits 3464 3465 +1
Misses 417 417
Continue to review full report at Codecov.
|
Looks great. Thanks for the quick PR! I think I missed out on mentioning the changes to the examples folder (you can ignore the "old" subfolder there). Should be good to merge once you've replaced those as well. |
@dhiganthrao Could you log a warning when |
Sure! I have done the same, please check and let me know if there are any errors. |
Looks good to me. @mynameisvinn we can let this warning remain for now and remove it once version control is out of alpha. |
Following up on a conversation with @AbhinavTuli and @mynameisvinn, I am creating a pull request to replace all mentions of
commit()
withflush()
, as thecommit()
method is deprecated. Please let me know if I've missed anything or need to further replace anything else. Thank you!