Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced commit() with flush() in documentation. #604

Merged
merged 3 commits into from
Feb 21, 2021
Merged

Replaced commit() with flush() in documentation. #604

merged 3 commits into from
Feb 21, 2021

Conversation

dhiganthrao
Copy link
Contributor

Following up on a conversation with @AbhinavTuli and @mynameisvinn, I am creating a pull request to replace all mentions of commit() with flush(), as the commit() method is deprecated. Please let me know if I've missed anything or need to further replace anything else. Thank you!

@github-actions
Copy link

Locust summary

Git references

Initial: c0317c5
Terminal: 7e5e40e

@codecov
Copy link

codecov bot commented Feb 20, 2021

Codecov Report

Merging #604 (db717c6) into master (c0317c5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #604   +/-   ##
=======================================
  Coverage   89.25%   89.25%           
=======================================
  Files          53       53           
  Lines        3881     3882    +1     
=======================================
+ Hits         3464     3465    +1     
  Misses        417      417           
Impacted Files Coverage Δ
hub/api/dataset.py 89.34% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0317c5...db717c6. Read the comment docs.

@AbhinavTuli
Copy link
Contributor

AbhinavTuli commented Feb 20, 2021

Looks great. Thanks for the quick PR! I think I missed out on mentioning the changes to the examples folder (you can ignore the "old" subfolder there). Should be good to merge once you've replaced those as well.

@mynameisvinn mynameisvinn added the documentation Improvements or additions to documentation label Feb 20, 2021
@mynameisvinn
Copy link
Contributor

@dhiganthrao Could you log a warning when Dataset.commit is invoked?

@dhiganthrao
Copy link
Contributor Author

Sure! I have done the same, please check and let me know if there are any errors.

@AbhinavTuli
Copy link
Contributor

Looks good to me. @mynameisvinn we can let this warning remain for now and remove it once version control is out of alpha.

@mynameisvinn mynameisvinn merged commit f0bddd7 into activeloopai:master Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants