-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Assertions from shape_detector.py and added exceptions #616
Conversation
Locust summaryGit referencesInitial: cc22f2fTerminal: 2c29de4 hub/store/shape_detector.pyChanges:
examples/large_dataset_build.pyChanges:
|
Looks good @DebadityaPal. Could you add a couple of unit tests for the new exceptions as well? Ideally, we want 100% codecov/patch at all times. |
Codecov Report
@@ Coverage Diff @@
## master #616 +/- ##
=======================================
Coverage 89.32% 89.33%
=======================================
Files 54 54
Lines 3925 3927 +2
=======================================
+ Hits 3506 3508 +2
Misses 419 419
Continue to review full report at Codecov.
|
Yes, I should have added the unit tests, it escaped my notice. I'll do it right away. |
@DebadityaPal you might want to check how to properly test exceptions using pytest. Here's an example from our tests |
@AbhinavTuli would it be helpful if I modified all the tests in the file to use the pytest format? |
Just merged it. Thanks for yet another great PR @DebadityaPal ! |
Some of the assertion errors were confusing, thus, explanations have been added. Solves #611