Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory benchmarks #638

Conversation

KrishnaChaitanya1
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Mar 2, 2021

Locust summary

Git references

Initial: e890baf
Terminal: 1c118a4

hub/api/dataset.py
Changes:
hub/api/sharded_datasetview.py
Changes:
hub/api/datasetview.py
Changes:
hub/api/tensorview.py
Changes:
hub/exceptions.py
Changes:
hub/store/azure_fs.py
Changes:
hub/store/shape_detector.py
Changes:
benchmarks/Memory Benchmarks/benchmark_memory_profile_hub.py
Changes:
benchmarks/Memory Benchmarks/benchmark_memory_profile_tf.py
Changes:
benchmarks/benchmark_tiledb_hub.py
Changes:
  • Name: time_tiledb
    Type: function
    Changed lines: 30
    Total lines: 30
    • Name: time_hub
      Type: function
      Changed lines: 17
      Total lines: 17
      benchmarks/benchmark_zarr_hub.py
      Changes:
      • Name: time_zarr
        Type: function
        Changed lines: 41
        Total lines: 41
        • Name: time_hub
          Type: function
          Changed lines: 17
          Total lines: 17
          examples/basic.py
          Changes:
          • Name: main
            Type: function
            Changed lines: 1
            Total lines: 23
            examples/big_image.py
            Changes:
            • Name: main
              Type: function
              Changed lines: 1
              Total lines: 21
              examples/large_dataset_build.py
              Changes:
              examples/mnist_upload_speed_benchmark.py
              Changes:
              • Name: main
                Type: function
                Changed lines: 1
                Total lines: 20
                examples/new_api_intro.py
                Changes:
                • Name: main
                  Type: function
                  Changed lines: 1
                  Total lines: 23
                  hub/api/tests/test_converters.py
                  Changes:
                  hub/api/tests/test_dataset.py
                  Changes:
                  hub/api/tests/test_objectview.py
                  Changes:
                  hub/api/tests/test_sharded_dataset.py
                  Changes:
                  hub/cli/auth.py
                  Changes:
                  • Name: register
                    Type: function
                    Changed lines: 1
                    Total lines: 17
                    hub/schema/bbox.py
                    Changes:
                    • Name: BBox
                      Type: class
                      Changed lines: 1
                      Total lines: 31
                      hub/store/tests/test_shape_detector.py
                      Changes:
                      hub/tests/test_exceptions.py
                      Changes:

                      @codecov
                      Copy link

                      codecov bot commented Mar 2, 2021

                      Codecov Report

                      Merging #638 (1c118a4) into master (8faed02) will not change coverage.
                      The diff coverage is n/a.

                      Impacted file tree graph

                      @@           Coverage Diff           @@
                      ##           master     #638   +/-   ##
                      =======================================
                        Coverage   88.46%   88.46%           
                      =======================================
                        Files          52       52           
                        Lines        3745     3745           
                      =======================================
                        Hits         3313     3313           
                        Misses        432      432           

                      Continue to review full report at Codecov.

                      Legend - Click here to learn more
                      Δ = absolute <relative> (impact), ø = not affected, ? = missing data
                      Powered by Codecov. Last update 8faed02...1c118a4. Read the comment docs.

                      @mynameisvinn mynameisvinn added the documentation Improvements or additions to documentation label Mar 3, 2021
                      @mynameisvinn
                      Copy link
                      Contributor

                      @KrishnaChaitanya1 thanks for this PR. Mind giving me some context behind this PR so I can provide feedback?

                      @benchislett
                      Copy link
                      Contributor

                      Hey guys. Good start on this, but I think we can get a bit more out of the tools. I'm going to branch off master and try to generalize our benchmarks so we get time, memory, and network on all metrics across the board. Updates to follow.

                      @KrishnaChaitanya1
                      Copy link
                      Contributor Author

                      @mynameisvinn . I asked @haiyangdeperci to see if the changes I made to memory benchmarks code is okay or not. Hence made this PR so that it can be checked. This PR is about the memory benchmarks which I tried using memory-profiler.

                      @benchislett
                      Copy link
                      Contributor

                      Proposing to close this in favor of #642 and move further discussion there.

                      @mynameisvinn
                      Copy link
                      Contributor

                      consolidating with #642

                      @mynameisvinn mynameisvinn self-requested a review March 7, 2021 12:00
                      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
                      Labels
                      documentation Improvements or additions to documentation
                      Projects
                      None yet
                      Development

                      Successfully merging this pull request may close these issues.

                      None yet

                      3 participants