Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/windows setup #650

Merged
merged 12 commits into from Mar 9, 2021
Merged

Fix/windows setup #650

merged 12 commits into from Mar 9, 2021

Conversation

haiyangdeperci
Copy link
Contributor

This PR adds a new section in the docs on Windows, reworks Getting Started guide and add support for loading hub as a module.

@github-actions
Copy link

github-actions bot commented Mar 5, 2021

Locust summary

Git references

Initial: a6da709
Terminal: a80736c

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #650 (2c9e0a4) into master (a6da709) will increase coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #650      +/-   ##
==========================================
+ Coverage   88.91%   89.08%   +0.16%     
==========================================
  Files          55       56       +1     
  Lines        3935     3938       +3     
==========================================
+ Hits         3499     3508       +9     
+ Misses        436      430       -6     
Impacted Files Coverage Δ
hub/__main__.py 0.00% <0.00%> (ø)
hub/api/dataset.py 89.34% <0.00%> (+1.52%) ⬆️
hub/client/hub_control.py 88.70% <0.00%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6da709...0231569. Read the comment docs.

@haiyangdeperci
Copy link
Contributor Author

Despite the failing patch, I think it should be merged as it brings code that is related to the CLI, for which we do not introduce tests (as it is not really feasible). See the CLI directory.

Provides a solution for #157.

@AbhinavTuli
Copy link
Contributor

Looks good! Let's get this merged quickly to help out windows users 😄

@haiyangdeperci haiyangdeperci merged commit 4314335 into master Mar 9, 2021
@haiyangdeperci
Copy link
Contributor Author

@AbhinavTuli I agree, done!

@haiyangdeperci haiyangdeperci deleted the fix/windows-setup branch April 9, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants