Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added region to S3 #715

Merged

Conversation

rawmarshmellows
Copy link
Contributor

No description provided.

@github-actions
Copy link

Locust summary

Git references

Initial: 96a3e49
Terminal: 2e2a748

hub/store/s3_file_system_replacement.py
Changes:
hub/store/s3_storage.py
Changes:
  • Name: S3Storage
    Type: class
    Changed lines: 4
    Total lines: 101
    Changes:

@kristinagrig06
Copy link
Contributor

kristinagrig06 commented Mar 25, 2021

@kevinlu1211, thanks for your pr. Will check why the tests are failing.

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #715 (ff283a5) into master (96a3e49) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #715   +/-   ##
=======================================
  Coverage   89.26%   89.26%           
=======================================
  Files          63       63           
  Lines        4378     4380    +2     
=======================================
+ Hits         3908     3910    +2     
  Misses        470      470           
Impacted Files Coverage Δ
hub/store/s3_file_system_replacement.py 100.00% <100.00%> (ø)
hub/store/s3_storage.py 83.60% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a3e49...ff283a5. Read the comment docs.

@kristinagrig06 kristinagrig06 merged commit 7b7af37 into activeloopai:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants