Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/circleci #719

Merged
merged 32 commits into from Mar 31, 2021
Merged

Fix/circleci #719

merged 32 commits into from Mar 31, 2021

Conversation

haiyangdeperci
Copy link
Contributor

This PR introduces Windows and MacOS tests, includes conda and refactored some of the linux test steps.

@github-actions
Copy link

Locust summary

Git references

Initial: 06cab25
Terminal: a508eb7

hub/api/dataset.py
Changes:
hub/api/integrations.py
Changes:
hub/api/tests/test_dataset.py
Changes:
hub/compute/transform.py
Changes:
hub/store/dynamic_tensor.py
Changes:
hub/api/datasetview.py
Changes:
hub/api/tensorview.py
Changes:
  • Name: TensorView
    Type: class
    Changed lines: 7
    Total lines: 335
    Changes:
hub/client/base.py
Changes:
hub/schema/class_label.py
Changes:
hub/schema/image.py
Changes:
  • Name: Image
    Type: class
    Changed lines: 6
    Total lines: 75
    Changes:
hub/store/metastore.py
Changes:
hub/api/tests/test_converters.py
Changes:
hub/cli/auth.py
Changes:
  • Name: reporting
    Type: function
    Changed lines: 1
    Total lines: 11
    hub/schema/bbox.py
    Changes:
    • Name: BBox
      Type: class
      Changed lines: 1
      Total lines: 57
      hub/schema/text.py
      Changes:
      • Name: Text
        Type: class
        Changed lines: 1
        Total lines: 49
        hub/store/tests/test_dynamic_tensor.py
        Changes:
        hub/utils.py
        Changes:
        • Name: batchify
          Type: function
          Changed lines: 2
          Total lines: 9

          @haiyangdeperci
          Copy link
          Contributor Author

          Fixed issues with Mac, all the tests pass. As for Windows, I think the tests have encountered a bug with dataset copying that is exclusive to windows. I'll investigate and I'll write more about it.

          @haiyangdeperci
          Copy link
          Contributor Author

          It seems like there is an issue with dataset copying on Windows. This inline python code would print [0 1 2 3 4] on Linux/Mac and [0 0 0 0 0] on Windows:

          python -c "import hub; from hub.cli.auth import login_fn; import numpy as np; login_fn('testingacc', os.getenv('ACTIVELOOP_HUB_PASSWORD')); ds = hub.Dataset('./dataset_copying', shape=(5,), schema={'num': 'uint8'}); ds['num'] = np.arange(5); ds2 = ds.copy('testingacc/dataset_copying'); print(ds2['num'].compute())"
          

          @haiyangdeperci
          Copy link
          Contributor Author

          Since the only issue with this PR is actually the bug with hub on Windows (which is a separate issue) I propose that it is merged.

          @verbose-void
          Copy link
          Contributor

          windows complex test fails?

          @haiyangdeperci
          Copy link
          Contributor Author

          @McCrearyD this PR introduces Windows Complex Test :) as explained above, it fails due to the same reason as #702

          @verbose-void
          Copy link
          Contributor

          ok

          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
          Labels
          None yet
          Projects
          None yet
          Development

          Successfully merging this pull request may close these issues.

          None yet

          2 participants