Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue when overwriting transform datasets #724

Merged
merged 1 commit into from Mar 31, 2021

Conversation

AbhinavTuli
Copy link
Contributor

@AbhinavTuli AbhinavTuli commented Mar 29, 2021

The below code earlier gave an error "AttributeError: 'Dataset' object has no attribute '_chunk_commit_map'"

ds_transform = some_transform(iterable)
ds = ds_transform.store("abcd/ds_name")
ds = ds_transform.store("abcd/ds_name")

This has now been fixed.

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #724 (fc864eb) into master (f688ec3) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
+ Coverage   89.30%   89.54%   +0.23%     
==========================================
  Files          65       65              
  Lines        4423     4427       +4     
==========================================
+ Hits         3950     3964      +14     
+ Misses        473      463      -10     
Impacted Files Coverage Δ
hub/api/dataset.py 91.70% <100.00%> (ø)
hub/store/metastore.py 91.89% <100.00%> (+6.84%) ⬆️
hub/store/s3_storage.py 88.52% <0.00%> (+4.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f688ec3...fc864eb. Read the comment docs.

@AbhinavTuli AbhinavTuli merged commit 059500f into master Mar 31, 2021
@kristinagrig06 kristinagrig06 deleted the fixes/transform_overwrite branch May 31, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants