Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default text dtype #737

Merged
merged 3 commits into from Apr 21, 2021
Merged

Changed default text dtype #737

merged 3 commits into from Apr 21, 2021

Conversation

AbhinavTuli
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Apr 1, 2021

Locust summary

Git references

Initial: ace84e5
Terminal: fec8880

hub/schema/text.py
Changes:
  • Name: Text
    Type: class
    Changed lines: 1
    Total lines: 109
    Changes:

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #737 (1b74aee) into master (a9d4d30) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #737   +/-   ##
=======================================
  Coverage   89.48%   89.48%           
=======================================
  Files          65       65           
  Lines        4423     4423           
=======================================
  Hits         3958     3958           
  Misses        465      465           
Impacted Files Coverage Δ
hub/schema/text.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d4d30...1b74aee. Read the comment docs.

@Diveafall
Copy link
Contributor

Hey @AbhinavTuli!

Please fix the tests so we can merge this.

@AbhinavTuli
Copy link
Contributor Author

I would have but I'm not sure what's going wrong 😅, it's just some package/Python macOS tests that are failing

@AbhinavTuli AbhinavTuli merged commit db32350 into master Apr 21, 2021
@kristinagrig06 kristinagrig06 deleted the fix/text_type branch May 31, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants