Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added store to DatasetView #740

Merged
merged 2 commits into from Apr 2, 2021
Merged

Added store to DatasetView #740

merged 2 commits into from Apr 2, 2021

Conversation

AbhinavTuli
Copy link
Contributor

Filtered or subsets of Datasets stored as DatasetView can now be stored as new Datasets

@github-actions
Copy link

github-actions bot commented Apr 2, 2021

Locust summary

Git references

Initial: fd234fd
Terminal: 9346b53

hub/api/dataset.py
Changes:
  • Name: Dataset
    Type: class
    Changed lines: 40
    Total lines: 966
    Changes:
    • Name: Dataset.store
      Type: function
      Changed lines: 39
      Total lines: 39
    hub/api/dataset_utils.py
    Changes:
    hub/api/datasetview.py
    Changes:
    hub/api/tests/test_dataset.py
    Changes:

    @codecov
    Copy link

    codecov bot commented Apr 2, 2021

    Codecov Report

    Merging #740 (cb93f48) into master (ace84e5) will increase coverage by 0.02%.
    The diff coverage is 100.00%.

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##           master     #740      +/-   ##
    ==========================================
    + Coverage   89.48%   89.51%   +0.02%     
    ==========================================
      Files          65       65              
      Lines        4395     4406      +11     
    ==========================================
    + Hits         3933     3944      +11     
      Misses        462      462              
    Impacted Files Coverage Δ
    hub/api/dataset.py 91.73% <100.00%> (+0.03%) ⬆️
    hub/api/dataset_utils.py 95.55% <100.00%> (+0.24%) ⬆️
    hub/api/datasetview.py 91.61% <100.00%> (+0.10%) ⬆️

    Continue to review full report at Codecov.

    Legend - Click here to learn more
    Δ = absolute <relative> (impact), ø = not affected, ? = missing data
    Powered by Codecov. Last update ace84e5...cb93f48. Read the comment docs.

    Copy link
    Contributor

    @Diveafall Diveafall left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This is awesome!

    @AbhinavTuli AbhinavTuli merged commit f19d566 into master Apr 2, 2021
    @kristinagrig06 kristinagrig06 deleted the feature/dsv_store branch May 31, 2021 13:00
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    2 participants