Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/hello objectron notebook #749

Merged
merged 7 commits into from Apr 8, 2021
Merged

Conversation

haiyangdeperci
Copy link
Contributor

This PR adds the requested filtering.

@github-actions
Copy link

github-actions bot commented Apr 6, 2021

Locust summary

Git references

Initial: 3e86342
Terminal: 76257f4

hub/api/dataset.py
Changes:
benchmarks/benchmark_dataset_comparison.py
Changes:
hub/api/integrations.py
Changes:
hub/api/tests/test_dataset.py
Changes:
hub/store/dynamic_tensor.py
Changes:
hub/api/datasetview.py
Changes:
hub/store/metastore.py
Changes:
hub/api/tensorview.py
Changes:
  • Name: TensorView
    Type: class
    Changed lines: 7
    Total lines: 335
    Changes:
hub/client/base.py
Changes:
hub/compute/transform.py
Changes:
  • Name: Transform
    Type: class
    Changed lines: 10
    Total lines: 399
    Changes:
hub/exceptions.py
Changes:
hub/report.py
Changes:
hub/schema/class_label.py
Changes:
hub/schema/image.py
Changes:
  • Name: Image
    Type: class
    Changed lines: 6
    Total lines: 75
    Changes:
benchmarks/benchmark_compress_time.py
Changes:
benchmarks/benchmark_dataset_iter.py
Changes:
benchmarks/benchmark_random_access.py
Changes:
benchmarks/benchmark_sequential_access.py
Changes:
  • Name: time_batches
    Type: function
    Changed lines: 23
    Total lines: 23
    • Name: time_tiledb
      Type: function
      Changed lines: 56
      Total lines: 56
      • Name: time_zarr
        Type: function
        Changed lines: 36
        Total lines: 36
        • Name: time_hub
          Type: function
          Changed lines: 11
          Total lines: 11
          benchmarks/benchmark_sequential_write.py
          Changes:
          • Name: time_batches
            Type: function
            Changed lines: 25
            Total lines: 25
            • Name: time_tiledb
              Type: function
              Changed lines: 25
              Total lines: 25
              • Name: time_zarr
                Type: function
                Changed lines: 12
                Total lines: 12
                • Name: time_hub
                  Type: function
                  Changed lines: 22
                  Total lines: 22
                  hub/api/tests/test_converters.py
                  Changes:
                  hub/cli/auth.py
                  Changes:
                  • Name: reporting
                    Type: function
                    Changed lines: 1
                    Total lines: 11
                    hub/schema/bbox.py
                    Changes:
                    • Name: BBox
                      Type: class
                      Changed lines: 1
                      Total lines: 57
                      hub/schema/deserialize.py
                      Changes:
                      • Name: deserialize
                        Type: function
                        Changed lines: 2
                        Total lines: 123
                        hub/schema/tests/test_features.py
                        Changes:
                        hub/schema/text.py
                        Changes:
                        • Name: Text
                          Type: class
                          Changed lines: 1
                          Total lines: 49
                          hub/store/tests/test_dynamic_tensor.py
                          Changes:
                          hub/utils.py
                          Changes:
                          • Name: batchify
                            Type: function
                            Changed lines: 2
                            Total lines: 9

                            @codecov
                            Copy link

                            codecov bot commented Apr 6, 2021

                            Codecov Report

                            Merging #749 (a210eea) into master (3e86342) will increase coverage by 0.11%.
                            The diff coverage is n/a.

                            Impacted file tree graph

                            @@            Coverage Diff             @@
                            ##           master     #749      +/-   ##
                            ==========================================
                            + Coverage   89.54%   89.65%   +0.11%     
                            ==========================================
                              Files          65       65              
                              Lines        4418     4418              
                            ==========================================
                            + Hits         3956     3961       +5     
                            + Misses        462      457       -5     
                            Impacted Files Coverage Δ
                            hub/client/base.py 72.00% <0.00%> (+6.66%) ⬆️

                            Continue to review full report at Codecov.

                            Legend - Click here to learn more
                            Δ = absolute <relative> (impact), ø = not affected, ? = missing data
                            Powered by Codecov. Last update 3e86342...a210eea. Read the comment docs.

                            Copy link
                            Contributor

                            @Diveafall Diveafall left a comment

                            Choose a reason for hiding this comment

                            The reason will be displayed to describe this comment to others. Learn more.

                            Can we separate this into a notebook with a different name so that this doesn't get override the notebook created by @mynameisvinn. Feel free to rename Vinn's notebook if it makes more sense.

                            @Diveafall Diveafall merged commit 4d587b9 into master Apr 8, 2021
                            @Diveafall Diveafall deleted the feature/hello_objectron_notebook branch April 8, 2021 15:04
                            Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
                            Labels
                            None yet
                            Projects
                            None yet
                            Development

                            Successfully merging this pull request may close these issues.

                            None yet

                            2 participants