Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema check #788

Merged
merged 4 commits into from Apr 22, 2021
Merged

Schema check #788

merged 4 commits into from Apr 22, 2021

Conversation

AbhinavTuli
Copy link
Contributor

Adds a check to see if the schema argument provided differs from the schema stored in the dataset

@github-actions
Copy link

Locust summary

Git references

Initial: db32350
Terminal: bf445aa

hub/api/dataset.py
Changes:
  • Name: Dataset
    Type: class
    Changed lines: 3
    Total lines: 969
    Changes:
hub/exceptions.py
Changes:
hub/api/dataset_utils.py
Changes:
  • Name: same_schema
    Type: function
    Changed lines: 20
    Total lines: 20
    hub/api/tests/test_dataset.py
    Changes:

    @codecov
    Copy link

    codecov bot commented Apr 21, 2021

    Codecov Report

    Merging #788 (33cf2fe) into master (db32350) will increase coverage by 0.00%.
    The diff coverage is 93.75%.

    Impacted file tree graph

    @@           Coverage Diff           @@
    ##           master     #788   +/-   ##
    =======================================
      Coverage   89.48%   89.49%           
    =======================================
      Files          65       65           
      Lines        4423     4436   +13     
    =======================================
    + Hits         3958     3970   +12     
    - Misses        465      466    +1     
    Impacted Files Coverage Δ
    hub/api/dataset_utils.py 95.13% <90.00%> (-0.42%) ⬇️
    hub/api/dataset.py 91.73% <100.00%> (ø)
    hub/exceptions.py 98.73% <100.00%> (+0.03%) ⬆️

    Continue to review full report at Codecov.

    Legend - Click here to learn more
    Δ = absolute <relative> (impact), ø = not affected, ? = missing data
    Powered by Codecov. Last update db32350...33cf2fe. Read the comment docs.

    @AbhinavTuli AbhinavTuli merged commit 4168264 into master Apr 22, 2021
    @kristinagrig06 kristinagrig06 deleted the fix/schema_check branch May 31, 2021 13:15
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    2 participants