QuickPay: fix method signature on #void #1817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,7 +35,7 @@ def authorize(money, credit_card, options = {}) | |||
| end | |||
| end | |||
|
|
|||
| def void(identification) | |||
| def void(identification, options = {}) | |||
There was a problem hiding this comment.
Since it's not actually passed to anything, should it be _ or _options?
There was a problem hiding this comment.
Fair point; changed it to _options
girasquid
force-pushed
the
fix-quickpay-void-method-signature
branch
from
7d2b6f9
to
a590b1f
Compare
|
👍 |
|
Wonder if we can tests to ensure all the gateways have the same method signatures. |
ronnietaylor
pushed a commit
to veracross/active_merchant
that referenced
this pull request
Jun 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aprofeit @ivanfer
The QuickPay v10 integration's
voidmethod doesn't acceptoptions, which all other integrations do - this brings it into sync with the others.