Add missing methods to KomojuGateway #2303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shioyama
changed the title
Komoju supports `PATCH` requests to update existing payments, so adding that as an option to the `commit` method.
shioyama
force-pushed
the
komoju_token
branch
from
8dfed83
to
ab82d04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some missing features that Komoju now supports:
storemethod) (to enable payment profiles)POST(specifically:PATCH, which Komoju supports for updating payments)For more information see the Komoju docs on Tokens, Refunds, and patching payments. See also the list of parameters for the payment resource.
A PR with the tokens code was closed previously in #1941 due to staleness. Specs cover all new features and are passing. A review would be much appreciated!