Remove unused ActiveMerchant::Connection#handle_response method #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- looks to be implemented on each gateway within `PostsData` module - method doesn't seem to be called anywhere in code and passes test suite
bpollack
approved these changes
Jul 11, 2018
There was a problem hiding this comment.
LGTM. @bdewater or @jasonwebster , do you know if Shopify is using this internally? AM definitely isn't, and neither is Spreedly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a search throught AM and couldn't find anywhere where this code is being used and looks to be dead code.
handle_responseLooks to now be implemented on each gateway withinPostsDatamodule included onBilling::Gateway.There weren't any tests covering this in the test suite.
How?
ActiveMerchant::Connection#handle_responseFor Review
@berkcaputcu @jasonwebster