Realex: update avs/address code creation #2509
Conversation
The Billing Code XML element is currently only formatted correctly for GB AVS checks. This is where only the digits from the post code and the first line of the address are submitted with a “|” between. For example: <address type='billing'> <code>321|456</code> <country>GB</country> </address> However, for US and CA the full post code and address should be submitted. For example: <address type='billing'> <code>50001|Flat 123</code> <country>US</country> </address> We just need to introduce code here to only remove the non-digits when the country is GB. For all other countries the full zip and first line of the address should be submitted.
|
Thanks for the PR. If this is still relevant to you (sorry it's been awhile!), I'd appreciate at least some information about what this is correcting/fixing and why, and ideally also an equivalent note in the remote tests so we can verify that it works properly. |
|
@bpollack Thanks for following up. This change corrects AVS behavior for non-GB countries that support AVS through the Realex gateway. Here's the relevant Realex documentation that covers this functionality: https://developer.realexpayments.com/#!/api/fraud-management/avs. Essentially, only GB address should strip non-numeric characters from the postal code and first address line when constructing the Are you able to confirm if you're looking to add tests/assertions for this change to match the unit test assertions? |
No description provided.