Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Litle: Update schema and certification tests to v9.12 #2522

Closed

Conversation

curiousepic
Copy link
Contributor

Also updates Android Pay support to pass the ordersource correctly.

Unit:
32 tests, 137 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
28 tests, 117 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

I'm happy to consider an alternate method of passing the prelive url for the cert tests.

@davidsantoso
Copy link
Member

I'm happy to consider an alternate method of passing the prelive url for the cert tests.

@curiousepic was there an issue with the pervious setup of merging in a :url to the initializer? Seems like we could continue with that method and just update the URL in the certification test vs needing to passing in a new prelive_url: true option.

@curiousepic
Copy link
Contributor Author

@davidsantoso Good catch... not sure what happened there but it does seem to work fine. I'll switch back to that method.

Also updates Android Pay support to pass the ordersource correctly.

Unit:
32 tests, 137 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
28 tests, 117 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
@curiousepic
Copy link
Contributor Author

Actually it wasn't quite that simple, but found a good similar method.

Copy link
Member

@davidsantoso davidsantoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 !

@curiousepic curiousepic deleted the vantiv_upgrade branch August 25, 2017 14:13
@kjbkjb
Copy link

kjbkjb commented Sep 25, 2017

@curiousepic Thank you for maintaining the Vantiv/Litle AM module. It is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants