Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating card_expiration_date format to match current API #2535

Closed
wants to merge 1 commit into from
Closed

Updating card_expiration_date format to match current API #2535

wants to merge 1 commit into from

Conversation

vitork
Copy link

@vitork vitork commented Aug 3, 2017

Pagar.me now accepts card_expiration_date in the format MMYY or MMYYYY.
Ref.: https://docs.pagar.me/reference#criar-transacao

Fixes #2534

Pagar.me now accepts card_expiration_date in the format MMYY or MMYYYY.
Ref.: https://docs.pagar.me/reference#criar-transacao
@bpollack
Copy link
Contributor

@vitork If this is still relevant to you, would you mind adding at least unit tests, and ideally remote tests?

@bpollack bpollack added the gateway/fix Fixes a bug in Active Merchant label Jun 25, 2018
@vitork
Copy link
Author

vitork commented Jun 25, 2018

Hey @bpollack!

No, this is not relevant anymore. The gateway API has changed a lot and I believe the whole integration would need to be rebuilt. For that reason I've decided not to use Active Merchant for this specific gateway and to implement the integration manually since I'm using just some basic endpoints.

Unfortunately I don't have the time to implement the necessary changes for the API to work again at this moment, but I'll be happy to help in the future if the integration is still outdated.

If you don't mind, I'm closing this PR since the code changes here would not solve the problem at all. As for the issue #2534, I'm not sure if we should close it or leave it opened to sinalize that the gateway integration is not working.

Thanks!

@vitork vitork closed this Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gateway/fix Fixes a bug in Active Merchant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants