MiGS: improve test suite and SecureHash #2676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpollack
requested review from
curiousepic,
deedeelavinder,
dtykocki and
nfarve
|
(NB, #2257 did some of this work over a year ago; I didn't see it until after I'd done my own version.) |
bpollack
force-pushed
the
migs-am-fixes
branch
3 times, most recently
from
9cc7c29
to
394d39c
Compare
dtykocki
approved these changes
Dec 13, 2017
bpollack
force-pushed
the
migs-am-fixes
branch
from
394d39c
to
11d3a3d
Compare
bpollack
force-pushed
the
migs-am-fixes
branch
from
11d3a3d
to
840c2f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our test cards were out-of-date, and MiGS now requires SHA256 hashes.
Address both of these issues.
Closes #2257