Litle: Add Support for Echeck #2776
Conversation
| elsif check?(payment_method) | ||
| doc.echeck do | ||
| doc.accType(payment_method.account_type) | ||
| doc.accNum(payment_method.account_number) |
There was a problem hiding this comment.
We'll want to add this field to the scrub method
There was a problem hiding this comment.
And the scrub tests too, preferably.
| order_id: '38', | ||
| order_source: 'telephone' | ||
| }) | ||
| assert response = @gateway.authorize(3002, @authorize_check, options) | ||
| assert_success response | ||
| assert_equal 'Approved', response.message | ||
| end |
There was a problem hiding this comment.
I know Github can do weird things to how these diffs are displayed, but wanted to make sure that these lines 113 and 114 aren't missing from the above test, and same for 202/203
There was a problem hiding this comment.
Ooh look like it is. I think it was a merge conflict auto-merging thing. Will fix that.
| doc.litleTxnId(transaction_id) | ||
| doc.amount(money) if money | ||
| doc.send(refund_type(payment), transaction_attributes(options)) do | ||
| if payment.is_a?(String) || payment.is_a?(Numeric) |
There was a problem hiding this comment.
Why the need to check for a numeric type now?
There was a problem hiding this comment.
@dtykocki in the tests it was giving tokens/auth codes as numbers and not strings
There was a problem hiding this comment.
Doesn't authorization_from stringify them?
There was a problem hiding this comment.
Yeah authorization_from should turn them into strings so I'm a bit 😕 here.
There was a problem hiding this comment.
@dtykocki and @curiousepic So I can change remote tests so they pass only strings and not numbers. Cases like this:
There was a problem hiding this comment.
@nfarve - Try that and maybe we'll be able to remove that number check.
| add_echeck_purchase_params(doc, money, payment, options) | ||
| else | ||
| add_auth_purchase_params(doc, money, payment, options) | ||
| end |
There was a problem hiding this comment.
Maybe it's the naming of the methods being used in here in refund (add_echeck_purchase_params and add_auth_purchase_params) but do refunds require the exact same params as echeck and auth purchases?
There was a problem hiding this comment.
@dtykocki Litle allows for "credits" of non-vantiv (litle) transactions. In those cases you give it the same info as a purchase and they "credit" the amount instead.
|
@dtykocki and @curiousepic change all auth tokens to strings in remote test and got rid of test for numeric. |
test/unit/gateways/litle_test.rb
Outdated
| def test_successful_purchase_with_echeck | ||
| response = stub_comms do | ||
| @gateway.purchase(2004, @check) | ||
| end.respond_with(successful_purchase_with_echeck_response) |
There was a problem hiding this comment.
Nitpick: indentation is slightly off here.
nfarve
force-pushed
the
enrg_7183_2
branch
2 times, most recently
from
e445660
to
701ba48
Compare
Adds support for Echeck and tests for certification. Loaded suite test/remote/gateways/remote_litle_test ................................... 35 tests, 136 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Loaded suite test/unit/gateways/litle_test Started ................................... 35 tests, 151 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Adds support for Echeck and tests for certification.
Loaded suite test/remote/gateways/remote_litle_test
...................................
35 tests, 136 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Loaded suite test/unit/gateways/litle_test
Started
...................................
35 tests, 151 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications