Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe: mark UGX as a zero-decimal currency #2857

Closed
wants to merge 1 commit into from

Conversation

bpollack
Copy link
Contributor

Two remote tests fail with or without this change.

Unit: 122 tests, 651 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote: 59 tests, 253 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
96.6102% passed

Two remote tests fail with or without this change.

Unit: 122 tests, 651 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote: 59 tests, 253 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
96.6102% passed
Copy link
Contributor

@curiousepic curiousepic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dtykocki
Copy link

@bpollack I wonder what's up with the remote tests. All green here on a latest master:

64 tests, 291 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@dtykocki
Copy link

The above output was from ruby -Itest test/remote/gateways/remote_stripe_test.rb.

@bpollack
Copy link
Contributor Author

@dtykocki Well this is kind of exciting. Now they pass for me too. Maybe an API blip on their end? I'll update the commit message.

@bpollack bpollack closed this in 544be0d May 24, 2018
@bpollack bpollack deleted the ugx-now-zero-decimal branch May 24, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants