Kuski: do not send extraTaxes if no value provided #2886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failing remote test is a refund, which fails with a note that refunds for the test card aren't supported (I think; my Spanish isn't great). Unit: 8 tests, 45 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 9 tests, 27 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 88.8889% passed
bpollack
force-pushed
the
enrg-7572-kushki-taxes
branch
from
3e69b51
to
1e7d051
Compare
|
@curiousepic Could you take another look, if you don't mind? The first code didn't actually work as intended when I prodded; I added some extra regression tests and fixed the underlying issue. |
|
@curiousepic Specifically https://github.com/activemerchant/active_merchant/pull/2886/files#diff-154e23ec35747841db7f46d7dd8f137aR108 was needed to patch things up, and you can see the regression tests diving in pretty hard there. |
|
@bpollack I was actually wondering about that hash creation, but assumed the tests were sufficient 😕New ones look great 👍 |
|
@bpollack Wait, is there a reason there's no remote tests for extra_taxes? |
|
@curiousepic Yeah: I have absolutely no idea at all what reasonable values for that are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failing remote test is a refund, which fails with a note that
refunds for the test card aren't supported (I think; my Spanish isn't
great).
Unit: 8 tests, 45 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote: 9 tests, 27 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
88.8889% passed