Orbital - Support for stored credentials framework #3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknipp
commented
Jan 17, 2019
| @@ -30,7 +30,7 @@ module Billing #:nodoc: | |||
| class OrbitalGateway < Gateway | |||
| include Empty | |||
|
|
|||
| API_VERSION = '7.1' | |||
| API_VERSION = '7.7' | |||
There was a problem hiding this comment.
Upgrading from 7.1 to 7.7 seems like a big jump in version to me. Any concerns here? Should the upgrade be separate from the credentials update?
There was a problem hiding this comment.
I don't think so, shouldn't be a big deal if there was no change in behavior with tests.
| @@ -567,7 +582,7 @@ def test_american_requests_adhere_to_xml_schema | |||
| response = stub_comms do | |||
| @gateway.purchase(50, credit_card, :order_id => 1, :billing_address => address) | |||
| end.check_request do |endpoint, data, headers| | |||
| schema_file = File.read("#{File.dirname(__FILE__)}/../../schema/orbital/Request_PTI54.xsd") | |||
| schema_file = File.read("#{File.dirname(__FILE__)}/../../schema/orbital/Request_PTI77.xsd") | |||
There was a problem hiding this comment.
It felt appropriate to update the XSD used for tests to be consistent with the API version update. I left this as a distinct commit in case we decide against doing so.
jknipp
force-pushed
the
ECS-91-orbital-stored-credential-support
branch
2 times, most recently
from
0774277
to
20fc75d
Compare
Add support for Stored Credentials Framework (Cardholder vs Merchant Initiated transactions). Update the XSD schema in remote tests to the latest version since we upgraded the API version for stored credentials. ECS-91 Remote: 25 tests, 148 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 71 tests, 427 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed closes activemerchant#3117
jknipp
force-pushed
the
ECS-91-orbital-stored-credential-support
branch
from
20fc75d
to
ea2ad89
Compare
whitby3001
pushed a commit
to whitby3001/active_merchant
that referenced
this pull request
Sep 3, 2019
Add support for Stored Credentials Framework (Cardholder vs Merchant Initiated transactions). Update the XSD schema in remote tests to the latest version since we upgraded the API version for stored credentials. ECS-91 Remote: 25 tests, 148 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 71 tests, 427 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed closes activemerchant#3117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Stored Credentials Framework (Cardholder vs Merchant Initiated transactions).
Update the XSD schema in remote tests to the latest version since we upgraded the API version for stored credentials.
ECS-91
Remote:
25 tests, 148 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Unit:
71 tests, 427 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed