Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch order of Romania country codes #3125

Merged
merged 1 commit into from Jan 25, 2019

Conversation

molbrown
Copy link
Member

ROU is more current country code than ROM. Switched order so ROU is
populated over ROM, but Romania values can still be accessed via ROM
code.

ECS-120

Unit tests:
13 tests, 27 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@molbrown molbrown requested a review from a team January 25, 2019 15:36
Copy link
Member

@jknipp jknipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Had to 👀twice to notice the change.

ROU is more current country code than ROM. Switched order so ROU is
populated over ROM, but Romania values can still be accessed via ROM
code.

ECS-120

Unit tests:
13 tests, 27 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Closes activemerchant#3125
@molbrown molbrown merged commit e47a5a9 into activemerchant:master Jan 25, 2019
@molbrown molbrown deleted the ECS-120 branch January 25, 2019 15:49
whitby3001 pushed a commit to whitby3001/active_merchant that referenced this pull request Sep 3, 2019
ROU is more current country code than ROM. Switched order so ROU is
populated over ROM, but Romania values can still be accessed via ROM
code.

ECS-120

Unit tests:
13 tests, 27 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Closes activemerchant#3125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants