Update and rename paybox_direct.rb to paybox_direct3d.rb #3266
Conversation
integrating 3D Secure parameters
|
@jcpaybox Thank you for the PR! At first glance this looks like a useful addition. However, this gateway adapter has a lot of functionality that is useful apart from 3DS. Renaming the file is a pretty major change with little obvious benefits. Could you elaborate on why you renamed the file? Could we add these changes but leave the file name itself the same as it currently is? (We have done this elsewhere when extending existing gateway adapters with 3DS functionality.) |
|
Hello thank you for your message,
I am in the process of adding 3ds on behalf of the psp paybox, I am having difficulties running tests but I am confident I will finish the changes soon. I didn't want to disturb anyone, which is why I decided to rename the file.
The objective indeed is to push all the changes (once finiished) to the paybox direct original file.
If it makes more sense to just work on the original file I'll do so, no worries.
Cordialement, regards,
Jérôme CINTAS
Chef de projets / Project manager
Integration Services
sent from my mobile
…________________________________
From: Zeb DeOs <notifications@github.com>
Sent: Monday, July 8, 2019 10:47:04 PM
To: activemerchant/active_merchant
Cc: Jerome Cintas; Mention
Subject: Re: [activemerchant/active_merchant] Update and rename paybox_direct.rb to paybox_direct3d.rb (#3266)
*** EXTERNAL EMAIL, think before you click. ***
@jcpaybox<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjcpaybox&data=02%7C01%7Cjerome.cintas%40verifone.com%7C412dfadd231148b95ff908d703e56fdc%7C611a22d68c40495884e3ce47d8205d98%7C0%7C0%7C636982156269732989&sdata=XUKE3HcBnTt%2ByCRuMMz65FcYC0YVxs%2BsmR35cbU2u4U%3D&reserved=0> Thank you for the PR! At first glance this looks like a useful addition. However, this gateway adapter has a lot of functionality that is useful apart from 3DS. Renaming the file is a pretty major change with little obvious benefits. Could you elaborate on why you renamed the file?
Could we add these changes but leave the file name itself the same as it currently is? (We have done this elsewhere when extending existing gateway adapters with 3DS functionality.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Factivemerchant%2Factive_merchant%2Fpull%2F3266%3Femail_source%3Dnotifications%26email_token%3DADTP5ZWDL56CHDIY6PUQ5XLP6ORURA5CNFSM4H5EZBX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZOJWBY%23issuecomment-509385479&data=02%7C01%7Cjerome.cintas%40verifone.com%7C412dfadd231148b95ff908d703e56fdc%7C611a22d68c40495884e3ce47d8205d98%7C0%7C0%7C636982156269742981&sdata=5JUC8%2BQmNMiNVTSvdrd1uJe4wEXb%2FpE1R%2BhPjsPOH9c%3D&reserved=0>, or mute the thread<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADTP5ZUR5W2DOHSFRGCVYF3P6ORURANCNFSM4H5EZBXQ&data=02%7C01%7Cjerome.cintas%40verifone.com%7C412dfadd231148b95ff908d703e56fdc%7C611a22d68c40495884e3ce47d8205d98%7C0%7C0%7C636982156269742981&sdata=mOwaL4XULFBgyPbAW%2FXPh8VhpeToFm4%2F3f9sMUL8NRQ%3D&reserved=0>.
|
|
Excellent, thank you for the clarification. While you're working from your in-progress fork/branch there should be no problems either way, so please feel free to continue working in the way that best suits your needs and workflow. We can squash intervening commits and there will be no difference as long as the final commits have returned the file to the original name. Please let me know if you have any questions in the mean time! |
|
@jcpaybox just wanted to give you the heads up that we've begun to document the emerging conventions for adding 3DS auth support to gateways (especially for 3DS 2 auth support). Not sure if this aligns with what you're working on now, but wanted to point it out just in case it does. https://github.com/activemerchant/active_merchant/wiki/Standardized-3DS-Fields |
integrating 3D Secure parameters
according to our API integration manual, and adapting parameter to your own MPI (we normally use or own MPI service).
ManuelIntegrationVerifone_PayboxDirect_V8.1_EN.pdf