Add shipping info to Stripe purchases #3315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "shipping" parameter for Stripe is optional, but when it is specified the "name" and "address" fields are required, and "address" in turn requires "line1". Validate that those are present before we attempt to add shipping information, this should prevent transaction errors due to incomplete information. See https://stripe.com/docs/api/charges/create#create_charge-shipping Addresses issue raised in 28eb2a8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon the work done by @whitby3001 in #2379
That PR was reverted in 28eb2a8 due to validation errors from Stripe with incomplete shipping information. I've added checks to ensure all required fields are present and added some test coverage for this case.
Stripe docs on required parameters: https://stripe.com/docs/api/charges/create#create_charge-shipping