Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rubocop: Style/IfUnlessModifier #3390

Closed
wants to merge 1 commit into from
Closed

Rubocop: Style/IfUnlessModifier #3390

wants to merge 1 commit into from

Conversation

nfarve
Copy link

@nfarve nfarve commented Oct 14, 2019

Handles rubocop todo for styling one line if/unless statements.

@nfarve nfarve requested a review from a team October 14, 2019 15:45
molbrown
molbrown approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@molbrown molbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Netbanx now has an additional multiline if/else causing conflict, otherwise 👍

Rubocop: Style/IfUnlessModifier
1d424b0 
Handles rubocop todo for styling one line if/unless statements.
@nfarve nfarve closed this Oct 23, 2019
@nfarve nfarve deleted the rubocop branch October 23, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molbrown molbrown molbrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nfarve @molbrown