Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth.net: Ensure proper parsing when quotes in direct_response #3479

Conversation

britth
Copy link
Contributor

@britth britth commented Dec 31, 2019

Some transactions are getting marked as failures due to improper
parsing when there are quotes in direct_response field. PR removes
extra quotes from direct_response field so that separate delimited
fields can be correctly parsed.

Unit:
97 tests, 575 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
69 tests, 238 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@britth britth requested a review from a team December 31, 2019 22:02
@britth britth changed the title Auth.net: Ensure proper escaping in when quotes in direct_response Auth.net: Ensure proper parsing when quotes in direct_response Dec 31, 2019
Copy link
Contributor

@jeremywrowe jeremywrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Some transactions are getting marked as failures due to improper
parsing when there are quotes in direct_response field. PR removes
extra quotes from `direct_response` field so that separate delimited
fields can be correctly parsed.

Unit:
97 tests, 575 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
69 tests, 238 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
@britth britth force-pushed the ECS-848-auth-net-direct-response-parsing branch from 8c32f3d to 70cd0a0 Compare January 2, 2020 17:03
@britth britth merged commit 70cd0a0 into activemerchant:master Jan 2, 2020
@britth britth deleted the ECS-848-auth-net-direct-response-parsing branch January 2, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants