Credorax: Update non-standard currencies list #3499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinhle23-zz
force-pushed
the
ECS-978_credorax_update_non_standard_currencies
branch
from
cb53e6c
to
4774c70
Compare
britth
approved these changes
Jan 14, 2020
test/unit/gateways/credorax_test.rb
Outdated
| stub_comms do | ||
| @gateway.authorize(200, @credit_card, @options.merge(currency: 'JPY')) | ||
| end.check_request do |endpoint, data, headers| | ||
| p data |
There was a problem hiding this comment.
Yikes, thanks for catching that!
chinhle23-zz
force-pushed
the
ECS-978_credorax_update_non_standard_currencies
branch
from
4774c70
to
d688e90
Compare
ECS-978 Per Credorax's latest [API docs](https://epower.credorax.com/wp-content/uploads/2019/11/Credorax-Source-Payment-API-Specifications-v1.3-.pdf), their zero-decimal and three-decimal currencies list have changed: - Add BIF, DJF, GNF, KMF, RWF, VUV, XAF, XOF, & XPF to the `currencies_without_fractions` list - Add IQD & LYD and remove RSD from the `currencies_with_three_decimal_places` list Some remote tests may fail due to Credorax's remote server timing out, thus not related to these updates. The specific tests failing or error'ing may change with each run. Unit: 63 tests, 301 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 40 tests, 147 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
chinhle23-zz
force-pushed
the
ECS-978_credorax_update_non_standard_currencies
branch
from
d688e90
to
661ecd7
Compare
chinhle23-zz
deleted the
ECS-978_credorax_update_non_standard_currencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECS-978
Per Credorax's latest API docs,
their zero-decimal and three-decimal currencies list have changed:
currencies_without_fractionslist
currencies_with_three_decimal_placeslist
Some remote tests may fail due to Credorax's remote server timing out, thus
not related to these updates. The specific tests failing or error'ing may
change with each run.
Unit:
63 tests, 301 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
40 tests, 147 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed