Adyen: Fail unexpected 3DS responses #3546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curiousepic
force-pushed
the
ECS_1015_adyen_3ds_kerfuffle
branch
3 times, most recently
from
9bd4572
to
7b863ae
Compare
britth
reviewed
Feb 26, 2020
| @@ -520,7 +520,12 @@ def request_headers(options) | |||
| headers | |||
| end | |||
|
|
|||
| def success_from(action, response) | |||
| def success_from(action, response, options) | |||
| if response.dig('resultCode') == 'RedirectShopper' && !options[:execute_threed] && !options[:threed_dynamic] | |||
There was a problem hiding this comment.
I know it's possible sometimes to have a direct challenge that skips the RedirectShooper result code and goes straight to ChallengeShopper - would that be possible in the dynamic 3ds scenario and do we need to check for that as well?
There was a problem hiding this comment.
Great question, I'm not sure if it's possible but it seems like a good idea to add it to the criteria.
There are certain situations where the initiator of a transaction is not expecting or prepared to complete a 3DS challenge flow, yet an authorize transaction triggers a 3DS auth response from Adyen. Previously, if a 3DS flow was not expected, a Purchase was initiated, and the auth step received a 3ds authentication response, the adapter would assume the auth step succeeded, and perform the capture, for which Adyen's response is not sufficient to indicate the money was actually moved. This means the Purchase would be assumed to succeed when in fact it was stalled at the 3DS auth step. This change recognizes these situations and fails the transaction with a meaningful message. Remote: 82 tests, 276 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 59 tests, 279 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
curiousepic
force-pushed
the
ECS_1015_adyen_3ds_kerfuffle
branch
from
7b863ae
to
c1b645e
Compare
britth
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are certain situations where the initiator of a transaction is not
expecting or prepared to complete a 3DS challenge flow, yet an authorize
transaction triggers a 3DS auth response from Adyen.
Previously, if a 3DS flow was not expected, a Purchase was initiated,
and the auth step received a 3ds authentication response, the adapter
would assume the auth step succeeded, and perform the capture, for which
Adyen's response is not sufficient to indicate the money was actually
moved. This means the Purchase would be assumed to succeed when in fact
it was stalled at the 3DS auth step.
This change recognizes these situations and fails the transaction with a
meaningful message.
Remote:
82 tests, 276 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Unit:
59 tests, 279 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed