PayJunctionv2: Fix billing address fields #3557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leila-alderman
force-pushed
the
CE-437_payjunction_billing_address
branch
from
1da3dee
to
7e537a5
Compare
therufs
approved these changes
Feb 28, 2020
leila-alderman
force-pushed
the
CE-437_payjunction_billing_address
branch
from
7e537a5
to
f3f2fd2
Compare
|
@therufs Thank you for the super speedy review! 🏆 |
The billing address fields were recently added to the PayJunctionv2 gateway but were mapped to incorrect fields for the gateway. This update corrects these fields to send the data in the correctly named fields according to [PayJunction's documentation](https://developer.payjunction.com/hc/en-us/articles/216477407-POST-transactions). In addition, new remote test assertions were added to ensure that the gateway is correctly receiving and returning the billing address fields in the response. CE-437 Unit: 19 tests, 87 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 20 tests, 63 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed All unit tests: 4464 tests, 71595 assertions, 0 failures, 0 errors, 0 pendings, 2 omissions, 0 notifications 100% passed
leila-alderman
force-pushed
the
CE-437_payjunction_billing_address
branch
from
f3f2fd2
to
65db5c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The billing address fields were recently added to the PayJunctionv2
gateway but were mapped to incorrect fields for the gateway.
This update corrects these fields to send the data in the correctly
named fields according to PayJunction's documentation.
In addition, new remote test assertions were added to ensure that the
gateway is correctly receiving and returning the billing address fields
in the response.
CE-437
Unit:
19 tests, 87 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed
Remote:
20 tests, 57 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions,
0 notifications
100% passed
All unit tests:
4464 tests, 71595 assertions, 0 failures, 0 errors, 0 pendings, 2
omissions, 0 notifications
100% passed