Adyen: Correctly parse error messages for 3DS2 auths #3619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curiousepic
approved these changes
May 7, 2020
britth
force-pushed
the
ecs-1221-adyen-properly-parse-3ds2-message
branch
from
d2e3e93
to
ab5f939
Compare
When 3DS2 fails, Adyen will return an error under refusalReason. Previously, we were checking for this value with the `authorise` and the `authorise3d` endpoints, but not for `authorise3ds2`. Updates message_from to properly check for the refusal reason when present for 3DS2 txns. Unit: 66 tests, 315 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 89 tests, 343 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
britth
force-pushed
the
ecs-1221-adyen-properly-parse-3ds2-message
branch
from
ab5f939
to
8b462de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When 3DS2 fails, Adyen will return an error under refusalReason.
Previously, we were checking for this value with the
authoriseand the
authorise3dendpoints, but not forauthorise3ds2.Updates message_from to properly check for the refusal reason when
present for 3DS2 txns.
Unit:
66 tests, 315 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
89 tests, 343 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed