Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realex: Remove support for network tokenization #3638

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Carrigan
Copy link
Contributor

Why?

Discussions with the Realex support team have revealed that these fields are not actually supported.

What Changed?

This pull request removes support for network tokenized cards on the Realex gateway.

Test Suite

4503 tests, 71981 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@Carrigan Carrigan requested a review from a team May 19, 2020 21:40
Copy link
Contributor

@britth britth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@molbrown
Copy link
Member

👀 What is that test output? I get one unrelated local remote test failing, which is also failing for me on master: test_realex_purchase_with_invalid_account.

@Carrigan
Copy link
Contributor Author

@molbrown what is the error you are getting? It is passing for me locally:

25 tests, 131 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@molbrown
Copy link
Member

Sorry I missed this, I get a different result code in test_realex_purchase_with_invalid_account, but I also get this failure on master, and it is unrelated to your changes. I would add your test output to the commit message as well.

ECS-1186

Discussions with the Realex support team have revealed that these fields
are not actually supported.

This pull request removes support for network tokenized cards on the
Realex gateway.

rake test:local
4503 tests, 71981 assertions, 0 failures, 0 errors, 0 pendings,
0 omissions, 0 notifications
100% passed

test/remote/gateways/remote_realex_test.rb
25 tests, 131 assertions, 0 failures, 0 errors, 0 pendings,
0 omissions, 0 notifications
100% passed
@Carrigan Carrigan force-pushed the ecs-1186-remove-realex-network-tokenization branch from cfcee5e to d8eafcf Compare May 22, 2020 19:53
@Carrigan
Copy link
Contributor Author

I updated my commit message with local and remote test outputs 👍

Copy link
Member

@molbrown molbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks, looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants