Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimplePay gateways implementation. #4016

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

simahero
Copy link

Dear ActiveMerchant Team!

The gateway I would like to get accepted is quite complicated and I would like to get some reviews on how to imporve it to fit to your scheme.

In the contribution documentation, it is mentioned, that the option hash should be as it is, but I am afraid it is impossible to do it in SimplePay's case. There is just so much data, that would not fit in the scheme.

I have also wrote a detailed documentation for this specific gateway, which is aviable here: https://github.com/simahero/active_merchant/wiki

Reading the documentation, you might see, how it gets tricky when browser information, tokens, secrets, multiple amounts are required to make a transaction happen.

I would really appreciate your time and help.

Best regard!

@simahero
Copy link
Author

I made a branch where I have refacted a lot of stuff to get closer to active merchants "style".

Should I make a pull request for that branch?
https://github.com/simahero/active_merchant/tree/refactor

Refactored:

  • no camelCase values in the options
  • amount, credit_card parametes as it should be (not in the options)
  • standard options hash keys, where it is possible (for example: :order_id)

Copy link

github-actions bot commented Jun 3, 2024

To provide a cleaner slate for the maintenance of the library, this PR/Issue is being labeled stale after 60 days without activity. It will be closed in 14 days unless you comment with an update regarding its applicability to the current build. Thank you!

@github-actions github-actions bot added the Stale label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant