Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CyberSource: handling not supported Network Token brands #4500

Closed
wants to merge 1 commit into from

Conversation

Heavyblade
Copy link
Collaborator

Summary:

This PR adds a check on Cybersource adapter to deal with not supported brands on Network Tokens.

Test Execution:

Remote
Finished in 91.83718 seconds.
115 tests, 590 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
97.3913% passed

Unit
5266 tests, 76138 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

RuboCop:

746 files inspected, no offenses detected

@Heavyblade Heavyblade force-pushed the disable_discover_for_ap_cybersource branch from 44e4d7f to ed1d12f Compare July 18, 2022 21:16
Copy link
Collaborator

@jherreraa jherreraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Summary:
------------------------------
This PR adds a check on Cybersource adapter to deal
with not supported brands on Network Tokens.

Test Execution:
------------------------------
Remote
Finished in 91.83718 seconds.
115 tests, 590 assertions, 3 failures, 0 errors, 0 pendings,
0 omissions, 0 notifications
97.3913% passed

Unit
5266 tests, 76138 assertions, 0 failures, 0 errors, 0 pendings,
0 omissions, 0 notifications
100% passed

RuboCop:
------------------------------
746 files inspected, no offenses detected
@Heavyblade Heavyblade force-pushed the disable_discover_for_ap_cybersource branch from ed1d12f to 4d246d4 Compare July 19, 2022 20:14
@Heavyblade Heavyblade marked this pull request as ready for review July 21, 2022 15:51
Copy link
Contributor

@curiousepic curiousepic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants