Element: fix bug with billing address email #4644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachelkirk
approved these changes
Dec 9, 2022
| @@ -248,6 +248,7 @@ def add_echeck(xml, payment) | |||
|
|
|||
| def add_address(xml, options) | |||
| if address = options[:billing_address] || options[:address] | |||
| address[:email] ||= options[:email] | |||
There was a problem hiding this comment.
had to google the ||= operator, first time i remember seeing it! :the_more_you_know:
Enables the `add_address` method to successfully find `email` whether it is nested at the top level of the `options` hash or within the `billing_address` object CER-330
jcreiff
force-pushed
the
CER-330_element_billing_email
branch
from
3dc489c
to
8214fb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the
add_addressmethod to successfully findemailwhether it is nested at the top level of theoptionshash or within thebilling_addressobjectCER-330
LOCAL
5411 tests, 76919 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
756 files inspected, no offenses detected
REMOTE
29 tests, 82 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed