DLocal: Add save field on card object #4785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcreiff
reviewed
May 25, 2023
| response = @gateway.purchase(@amount, @credit_card, @options.merge(save: true)) | ||
| assert_success response | ||
| assert_equal true, response.params['card']['save'] | ||
| assert_not_empty response.params['card']['card_id'] |
There was a problem hiding this comment.
Can you also assert that we're receiving the [card][type] in the response, since that's one of the motivations for adding this?
There was a problem hiding this comment.
Hey @jcreiff after a little more digging, I see that the card['type'] is not returned in the sandbox tests response even when calling verify instead of purchase. This may be a limitation of the gateway sandbox but if there's something I'm missing, please let me know, thanks!
There was a problem hiding this comment.
hey @jcreiff the sandbox is now returning the card type so i added the assertion to the remote test, thanks!
yunnydang
force-pushed
the
d_local_add_gateway_specific_field_save
branch
from
a974489
to
efa3694
Compare
yunnydang
changed the title
yunnydang
force-pushed
the
d_local_add_gateway_specific_field_save
branch
from
efa3694
to
51ec4f4
Compare
yunnydang
changed the title
yunnydang
force-pushed
the
d_local_add_gateway_specific_field_save
branch
from
51ec4f4
to
ae4b945
Compare
yunnydang
force-pushed
the
d_local_add_gateway_specific_field_save
branch
from
ae4b945
to
5a4ae34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the save field to card object, documentation found here
Local:
5512 tests, 77364 assertions, 0 failures, 19 errors, 0 pendings, 0 omissions, 0 notifications
99.6553% passed
Unit:
44 tests, 191 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
39 tests, 105 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
94.8718% passed