Shift4_v2: Inherit securionPay API to enable Shift4v2 #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinourain
reviewed
Aug 17, 2023
Heavyblade
force-pushed
the
SER-653_shift4_v2
branch
4 times, most recently
from
53686bb
to
d6c61de
Compare
Heavyblade
force-pushed
the
SER-653_shift4_v2
branch
2 times, most recently
from
58a0afc
to
f2aecbe
Compare
naashton
reviewed
Aug 22, 2023
naashton
approved these changes
Aug 22, 2023
Heavyblade
force-pushed
the
SER-653_shift4_v2
branch
4 times, most recently
from
25a1251
to
4a17fe9
Compare
Description ------------------------- [SER-653](https://spreedly.atlassian.net/browse/SER-653) [SER-654](https://spreedly.atlassian.net/browse/SER-654) [SER-655](https://spreedly.atlassian.net/browse/SER-655) [SER-662](https://spreedly.atlassian.net/browse/SER-662) Shift4 purchased Securion Pay and is now using their API, that's why this commit enable a new shift4_v2 gateway Unit test ------------------------- Finished in 0.150258 seconds. 34 tests, 191 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote test ------------------------- Finished in 28.137188 seconds. 30 tests, 103 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop ------------------------- 760 files inspected, no offenses detected
Heavyblade
force-pushed
the
SER-653_shift4_v2
branch
from
4a17fe9
to
1a9adcc
Compare
|
Latest changes applied @naashton. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SER-653
SER-654
SER-655
SER-661
SER-662
SER-663
Shift4 purchased Securion Pay and is now using their API, that's why
this commit enables a new shift4_v2 gateway
WIP: Pending to include general credit support
Unit test
Finished in 0.150258 seconds.
34 tests, 191 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
226.28 tests/s, 1271.15 assertions/s
Remote test
Finished in 27.855679 seconds.
33 tests, 116 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Rubocop
760 files inspected, no offenses detected