Rapyd: Update cvv behavior #4883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heavyblade
reviewed
Sep 8, 2023
There was a problem hiding this comment.
Looks pretty much OK @javierpedrozaing, left some style comments
javierpedrozaing
force-pushed
the
SER-808_Rapyd_update_cvv_behavior
branch
2 times, most recently
from
3829594
to
0107923
Compare
Description ------------------------- [SER-808](https://spreedly.atlassian.net/browse/SER-808) This commit validate if the cvv in order to don't allow send empty values to Rapyd This commit also include a small update for the previos work made for [3ds Gateway Specific](#4876) Unit test ------------------------- Finished in 0.183111 seconds. 29 tests, 148 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notificationsomissions, 0 notifications 100% passed 158.37 tests/s, 808.25 assertions/s Remote test ------------------------- Finished in 113.329864 seconds. 34 tests, 111 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.0588% passed 0.30 tests/s, 0.86 assertions/s Rubocop ------------------------- 763 files inspected, no offenses detected
javierpedrozaing
force-pushed
the
SER-808_Rapyd_update_cvv_behavior
branch
from
0107923
to
137539f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SER-808
This commit validate if the cvv in order to don't allow send empty values to Rapyd.
This commit also include a small update for the previos work made for 3ds Gateway Specific
Unit test
Finished in 0.183111 seconds.
29 tests, 148 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notificationsomissions, 0 notifications 100% passed
158.37 tests/s, 808.25 assertions/s
Remote test
Finished in 113.329864 seconds.
34 tests, 111 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.0588% passed
0.30 tests/s, 0.86 assertions/s
Rubocop
763 files inspected, no offenses detected