Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XpayGateway: initia Setup #4889

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

javierpedrozaing
Copy link
Collaborator

Description

SER-763

This commit add the initial setup for the new Xpay gateway

Unit test

Finished in 0.557754 seconds.

2 tests, 4 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

3.59 tests/s, 7.17 assertions/s

Remote test

Finished in 0.557754 seconds.

2 tests, 4 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

3.59 tests/s, 7.17 assertions/s

Rubocop

769 files inspected, no offenses detected

Copy link
Collaborator

@Heavyblade Heavyblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javierpedrozaing done with the review, left some general comments and a couple of warnings.

lib/active_merchant/billing/gateways/xpay.rb Outdated Show resolved Hide resolved
lib/active_merchant/billing/gateways/xpay.rb Show resolved Hide resolved
lib/active_merchant/billing/gateways/xpay.rb Show resolved Hide resolved
lib/active_merchant/billing/gateways/xpay.rb Show resolved Hide resolved
lib/active_merchant/billing/gateways/xpay.rb Outdated Show resolved Hide resolved
lib/active_merchant/billing/gateways/xpay.rb Outdated Show resolved Hide resolved
test/fixtures.yml Show resolved Hide resolved
lib/active_merchant/billing/gateways/xpay.rb Outdated Show resolved Hide resolved
lib/active_merchant/billing/gateways/xpay.rb Outdated Show resolved Hide resolved
test/unit/gateways/xpay_test.rb Show resolved Hide resolved
@javierpedrozaing javierpedrozaing force-pushed the SER-763_Xpay_gateway_initial_setup branch 2 times, most recently from 0fb35c1 to 1a10b8d Compare September 18, 2023 13:19
Copy link
Collaborator

@Heavyblade Heavyblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty much OK @javierpedrozaing, left couple coments

lib/active_merchant/billing/gateways/xpay.rb Show resolved Hide resolved
lib/active_merchant/billing/gateways/xpay.rb Show resolved Hide resolved
lib/active_merchant/billing/gateways/xpay.rb Show resolved Hide resolved
@javierpedrozaing javierpedrozaing marked this pull request as ready for review September 18, 2023 22:38
@naashton naashton force-pushed the SER-763_Xpay_gateway_initial_setup branch from d630de3 to 4356631 Compare September 20, 2023 19:07
Description
-------------------------
[SER-763](https://spreedly.atlassian.net/browse/SER-763)

This commit add the initial setup for the new Xpay gateway

Unit test
-------------------------
Finished in 0.557754 seconds.

2 tests, 4 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

3.59 tests/s, 7.17 assertions/s

Remote test
-------------------------
Finished in 0.557754 seconds.

2 tests, 4 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

3.59 tests/s, 7.17 assertions/s

Rubocop
-------------------------
769 files inspected, no offenses detected
@naashton naashton force-pushed the SER-763_Xpay_gateway_initial_setup branch from 4356631 to a33a5c8 Compare September 20, 2023 19:08
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@naashton naashton merged commit 8e375ec into master Sep 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants