Rapyd: fixing issue with json encoding and signatures #4892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naashton
force-pushed
the
fixing_bug_for_rapyd_signature
branch
from
17b2d83
to
9340d7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes a bug for Rapyd where the signature doesn't match the actual body and happens as a consequence of how ActiveSupport encodes some URL parameters.
ActiveSupport
SER-813
Note:
A failing test happens due to a reference that needs to be updated every time.
Tests
Remote Test:
Finished in 108.783668 seconds.
38 tests, 110 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
97.3684% passed
Unit Tests:
Finished in 37.178252 seconds.
5604 tests, 78022 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
RuboCop:
766 files inspected, no offenses detected