Cybersource Rest: Support NT #5107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almalee24
reviewed
Apr 26, 2024
| @@ -187,6 +203,34 @@ def test_add_shipping_address | |||
| assert_equal '4158880000', address[:phoneNumber] | |||
| end | |||
|
|
|||
| def test_authorize_network_token_visa | |||
There was a problem hiding this comment.
I know these tickets aren't together but could you please add tests for stored credentials just to ensure that we are properly sending all the fields.
There was a problem hiding this comment.
There's another PR to update the stored credential mappings!
almalee24
reviewed
Apr 26, 2024
almalee24
reviewed
Apr 26, 2024
| @@ -191,25 +196,31 @@ def add_payment(post, payment, options) | |||
| end | |||
|
|
|||
| def add_network_tokenization_card(post, payment, options) | |||
| post[:processingInformation][:paymentSolution] = PAYMENT_SOLUTION[payment.source] | |||
| post[:processingInformation][:commerceIndicator] = 'internet' unless card_brand(payment) == 'jcb' | |||
There was a problem hiding this comment.
commerceIndicator needs to be updated base on stored_credentials
There was a problem hiding this comment.
There's another PR that updates this value!
almalee24
reviewed
Apr 26, 2024
almalee24
reviewed
Apr 30, 2024
almalee24
reviewed
Apr 30, 2024
| else | ||
| post[:consumerAuthenticationInformation] = { cavv: payment.payment_cryptogram } | ||
| # Apple Pay / Google Pay | ||
| post[:processingInformation][:paymentSolution] = WALLET_PAYMENT_SOLUTION[payment.source] |
There was a problem hiding this comment.
Just to re-verify, it's necessary for us to send cryptogram in two different places for ApplePay & GooglePay?
almalee24
approved these changes
May 1, 2024
aenand
commented
May 1, 2024
| @@ -93,6 +98,7 @@ def scrub(transcript) | |||
| gsub(/(\\?"number\\?":\\?")\d+/, '\1[FILTERED]'). | |||
| gsub(/(\\?"routingNumber\\?":\\?")\d+/, '\1[FILTERED]'). | |||
| gsub(/(\\?"securityCode\\?":\\?")\d+/, '\1[FILTERED]'). | |||
| gsub(/(\\?"cryptogram\\?":\\?")[^<]+/, '\1[FILTERED]'). | |||
There was a problem hiding this comment.
@almalee24 also added scrubbing of cryptogram and a test for it.
COMP-75 Adds support for Network Tokens on the Cybersource Rest gateway. Test Summary Local: 5848 tests, 79228 assertions, 0 failures, 23 errors, 0 pendings, 0 omissions, 0 notifications 99.6067% passed Errors unrelated to this gateway Unit: 32 tests, 160 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 50 tests, 157 assertions, 7 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 86% passed Errors also on master
aenand
force-pushed
the
cybersource_rest_network_token
branch
from
593b285
to
f8281e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMP-75
Adds support for Network Tokens on the Cybersource Rest gateway.
Test Summary
Local:
5848 tests, 79228 assertions, 0 failures, 23 errors, 0 pendings, 0 omissions, 0 notifications 99.6067% passed
Errors unrelated to this gateway
Unit:
32 tests, 160 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Remote:
50 tests, 157 assertions, 7 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 86% passed
Errors also on master