FlexCharge: Adding support fot FlexCharge gateway #5108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heavyblade
force-pushed
the
add_flex_charge_gateway
branch
from
ef248f2
to
7e9adca
Compare
gasb150
reviewed
Apr 25, 2024
There was a problem hiding this comment.
@Heavyblade good job! I just left a few questions to clarify my understanding.
| end | ||
|
|
||
| def add_base_data(post, options) | ||
| post[:isDeclined] = cast_bool(options[:is_declined]) |
There was a problem hiding this comment.
Where comes this value that you should send a boolean, but it could be a set of different "false" related values?
There was a problem hiding this comment.
cast_bool is meant to boleans that come from GSFS, so I wanted to go full defensive covering different cases.
Summary: ------------------------------ This PR adds support for FlexCharge gateway adding the evaluate and refund operations [SER-1130](https://spreedly.atlassian.net/browse/SER-1130) Remote Test: ------------------------------ Finished in 39.651458 seconds. 12 tests, 40 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 91.6667% passed *Note:* Failing test happens because of account limit on refunds Unit Tests: ------------------------------ Finished in 33.453236 seconds. 5855 tests, 79334 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: ------------------------------ 795 files inspected, no offenses detected
Heavyblade
force-pushed
the
add_flex_charge_gateway
branch
from
7e9adca
to
373d545
Compare
naashton
approved these changes
May 2, 2024
| end | ||
|
|
||
| def refund(money, authorization, options = {}) | ||
| commit(:refund, { amountToRefund: (money.to_f / 100).round(2) }, authorization) |
There was a problem hiding this comment.
For the this money formatting, there is a helper method in the gateway.rb class called def localized_amount that you might be able to use instead.
Comment on lines
+56
to
+58
| gsub(%r(("mid\\?"\s*:\s*\\?")[^"]*)i, '\1[FILTERED]'). | ||
| gsub(%r(("siteId\\?"\s*:\s*\\?")[^"]*)i, '\1[FILTERED]'). | ||
| gsub(%r(("environment\\?"\s*:\s*\\?")[^"]*)i, '\1[FILTERED]'). |
There was a problem hiding this comment.
Do we need to scrub these?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds support for FlexCharge gateway adding the evaluate and refund operations
SER-1130
Tests
Remote Test:
Finished in 39.651458 seconds.
12 tests, 40 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
91.6667% passed
Note:
Failing test happens because of account limit on refunds
Unit Tests:
Finished in 33.453236 seconds.
5855 tests, 79334 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
RuboCop:
795 files inspected, no offenses detected