Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatrans: Add 3DS2 Global #5118

Merged
merged 1 commit into from May 17, 2024
Merged

Conversation

gasb150
Copy link
Collaborator

@gasb150 gasb150 commented May 7, 2024

Summary:

This includes to Datatrans gateway,
the params to required to support
3DS global.
SER-1197

Tests

Remote Test:
Finished in 24.693965 seconds.
21 tests, 55 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications 100% passed

Unit Tests:
24 tests, 129 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

RuboCop:
798 files inspected, no offenses detected

@gasb150 gasb150 marked this pull request as draft May 7, 2024 18:42
Copy link
Collaborator

@Heavyblade Heavyblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty much OK @gasb150

test/remote/gateways/remote_datatrans_test.rb Show resolved Hide resolved
@gasb150 gasb150 force-pushed the SER-1197_Datatrans_3DS_global branch 2 times, most recently from 335432b to 236b0cc Compare May 9, 2024 16:59
Base automatically changed from SER-1195_Datatrans_AP_GP_NT to master May 9, 2024 20:34
@gasb150 gasb150 force-pushed the SER-1197_Datatrans_3DS_global branch from 236b0cc to 484485d Compare May 10, 2024 19:43
@gasb150 gasb150 marked this pull request as ready for review May 10, 2024 19:43
@gasb150 gasb150 force-pushed the SER-1197_Datatrans_3DS_global branch 4 times, most recently from 320e19b to 8cad6a7 Compare May 15, 2024 19:35
@Heavyblade Heavyblade force-pushed the SER-1197_Datatrans_3DS_global branch from 8cad6a7 to b4fff07 Compare May 17, 2024 13:26
Summary:
-----

This includes to Datatrans gateway,
the params to required to support
3DS global.
[SER-1197](https://spreedly.atlassian.net/browse/SER-1197)

Tests
-----
Remote Test:
Finished in 24.693965 seconds.
21 tests, 55 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications
100% passed

Unit Tests:
24 tests, 129 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

RuboCop:
798 files inspected, no offenses detected
@Heavyblade Heavyblade force-pushed the SER-1197_Datatrans_3DS_global branch from b4fff07 to 3c8623b Compare May 17, 2024 13:30
@Heavyblade Heavyblade merged commit fe2142b into master May 17, 2024
0 of 5 checks passed
@Heavyblade Heavyblade deleted the SER-1197_Datatrans_3DS_global branch May 17, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants