Flex Charge: Add support for TPV store #5120
Conversation
| @@ -115,23 +135,29 @@ def add_invoice(post, money, credit_card, options) | |||
| avsResultCode: options[:avs_result_code], | |||
| cvvResultCode: options[:cvv_result_code], | |||
| cavvResultCode: options[:cavv_result_code], | |||
| cardNotPresent: credit_card.verification_value.blank? | |||
| cardNotPresent: credit_card.is_a?(String) ? false : credit_card.verification_value.blank? | |||
There was a problem hiding this comment.
Just confirming: for TPV the cardNotPresent value will always be false.
But for credit cards, will it be something true if no verification value is provided?
There was a problem hiding this comment.
Flex charge Documentation is not clear on this topic but the error messages during the testing led me to this conclusion.
edgarv09
force-pushed
the
SER-1149_flex_charge_store
branch
from
7c4f059
to
4bf9913
Compare
There was a problem hiding this comment.
@edgarv09 looks pretty much ok, left a couple comments for your consideration
| }.compact | ||
| } | ||
|
|
||
| post = { payment_method: payment_method } |
There was a problem hiding this comment.
💬 Comment / Style:
Is just matter of taste but, for your consideration =>
post[:payment_method] = {
credit_card: {
first_name: first_name,
last_name: last_name,
month: credit_card.month,
year: credit_card.year,
number: credit_card.number,
verification_value: credit_card.verification_value
}.compact
}| @@ -115,23 +135,29 @@ def add_invoice(post, money, credit_card, options) | |||
| avsResultCode: options[:avs_result_code], | |||
| cvvResultCode: options[:cvv_result_code], | |||
| cavvResultCode: options[:cavv_result_code], | |||
| cardNotPresent: credit_card.verification_value.blank? | |||
| cardNotPresent: credit_card.is_a?(String) ? false : credit_card.verification_value.blank? | |||
| }.compact | ||
| payment_method = case credit_card | ||
| when String | ||
| { token: true, cardNumber: credit_card } |
There was a problem hiding this comment.
❓ Question:
Is weird because I assume that it works for you but, does it work with token and Token ?
There was a problem hiding this comment.
It seems to work with lower/upper case.
| def authorization_from(response) | ||
| response[:orderSessionKey] | ||
| def authorization_from(action, response) | ||
| action == :store ? response[:transaction][:payment_method][:token] : response[:orderSessionKey] |
There was a problem hiding this comment.
💬 Comment:
Just in case of unexpected scenarios dig is a safer way to get the token
Test summary: Local: 5898 tests, 79569 assertions, 0 failures, 17 errors, 0 pendings, 0 omissions, 0 notifications 99.7118% passed Unit: 12 tests, 58 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 13 tests, 34 assertions, 1 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications 91.6667% passed
edgarv09
force-pushed
the
SER-1149_flex_charge_store
branch
from
4bf9913
to
5232f00
Compare
CHANGELOG
Outdated
| @@ -2,6 +2,7 @@ | |||
| = ActiveMerchant CHANGELOG | |||
|
|
|||
| == HEAD | |||
| * FlexCharge: Add support for TPV store [edgarv09] #5120 | |||
There was a problem hiding this comment.
💬 Comment,
This should be a the bottom of the block
Flex Charge: Add support for the TPV store
Test summary:
Local:
5898 tests, 79569 assertions, 0 failures, 17 errors, 0 pendings, 0 omissions, 0 notifications 99.7118% passed
Unit:
12 tests, 58 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Remote:
13 tests, 34 assertions, 1 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications 91.6667% passed