Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlexCharge: Add 3ds Global support #5121

Merged
merged 1 commit into from
May 17, 2024

Conversation

javierpedrozaing
Copy link
Collaborator

Description

This commit adds 3ds options for FlexCharge, adding suppport for 3ds Global

Unit test

13 tests, 70 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

480.43 tests/s, 2586.94 assertions/s

Remote test

Finished in 32.878446 seconds.

13 tests, 39 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications 100% passed

0.40 tests/s, 1.19 assertions/s

Rubocop

798 files inspected, no offenses detected

Copy link
Collaborator

@gasb150 gasb150 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just left a small comment for your consideration.

test/unit/gateways/flex_charge_test.rb Show resolved Hide resolved
@javierpedrozaing javierpedrozaing force-pushed the SER-1151_FlexCharge_add_three_ds_global branch from a7ddca4 to 79bd786 Compare May 17, 2024 16:42
@javierpedrozaing javierpedrozaing marked this pull request as ready for review May 17, 2024 16:43
Description
-------------------------
This commit adds 3ds options for FlexCharge, adding
suppport for 3ds Global

Unit test
-------------------------
13 tests, 70 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

480.43 tests/s, 2586.94 assertions/s

Remote test
-------------------------
Finished in 32.878446 seconds.

13 tests, 39 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications
100% passed

0.40 tests/s, 1.19 assertions/s

Rubocop
-------------------------
798 files inspected, no offenses detected
@Heavyblade Heavyblade force-pushed the SER-1151_FlexCharge_add_three_ds_global branch from 79bd786 to f140523 Compare May 17, 2024 16:51
@Heavyblade Heavyblade merged commit a74cbe1 into master May 17, 2024
0 of 5 checks passed
@Heavyblade Heavyblade deleted the SER-1151_FlexCharge_add_three_ds_global branch May 17, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants