Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HiPay: Fix mastercard brand mapping #5131

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

javierpedrozaing
Copy link
Collaborator

Description

This commit fix a issue for set the payment method brand for payment_product when is mastercard

Unit test

Finished in 1.799922 seconds.

24 tests, 64 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

13.33 tests/s, 35.56 assertions/s

Remote test

Finished in 132.781957 seconds.

18 tests, 76 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications

Rubocop

798 files inspected, no offenses detected

Description
-------------------------
This commit fix a issue for set the payment method brand
for payment_product when is mastercard

Unit test
-------------------------
Finished in 1.799922 seconds.

24 tests, 64 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

13.33 tests/s, 35.56 assertions/s

Remote test
-------------------------

Finished in 132.781957 seconds.

18 tests, 76 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications

Rubocop
-------------------------
798 files inspected, no offenses detected
@javierpedrozaing javierpedrozaing marked this pull request as ready for review May 22, 2024 15:48
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@naashton naashton merged commit 23cc081 into master May 23, 2024
0 of 5 checks passed
@naashton naashton deleted the hipay_fix_mastercard_mapping branch May 23, 2024 17:48
edgarv09 pushed a commit that referenced this pull request Jun 6, 2024
Description
-------------------------
This commit fix a issue for set the payment method brand
for payment_product when is mastercard

Unit test
-------------------------
Finished in 1.799922 seconds.

24 tests, 64 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

13.33 tests/s, 35.56 assertions/s

Remote test
-------------------------

Finished in 132.781957 seconds.

18 tests, 76 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications

Rubocop
-------------------------
798 files inspected, no offenses detected

Co-authored-by: Javier Pedroza <jpedroza@spreedly.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants