CyberSource: Update Stored Credential flow #5136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almalee24
reviewed
Jun 4, 2024
| @@ -862,11 +866,21 @@ def add_threeds_2_ucaf_data(xml, payment_method, options) | |||
| def stored_credential_commerce_indicator(options) | |||
| return unless options[:stored_credential] | |||
|
|
|||
| return if options[:stored_credential][:initial_transaction] | |||
| if options[:stored_credential][:initial_transaction] | |||
There was a problem hiding this comment.
I think it's best just to remove lines 869-875 since it doesn't work and we haven't heard back from Cybersource.
sinourain
force-pushed
the
ECS-3532_CyberSource_Update_Stored_Credential_flow
branch
from
2eb3f92
to
edcfdde
Compare
sinourain
changed the title
almalee24
force-pushed
the
ECS-3532_CyberSource_Update_Stored_Credential_flow
branch
3 times, most recently
from
0dfe063
to
79c1c43
Compare
bradbroge
approved these changes
Jun 24, 2024
I ended up removing that because it wasn't working when testing remotely and I didn't hear back from the CyberSource on why this was failing. |
Always send commerceIndicator if stored credential reason_type is present. Update the value send for NetworkTokens commerceIndicator based on if they are using stored credentials. Spreedly reference: [ECS-3532](https://spreedly.atlassian.net/browse/ECS-3532) Unit tests Finished in 26.745895 seconds. 5912 tests, 79756 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop 798 files inspected, no offenses detected
almalee24
force-pushed
the
ECS-3532_CyberSource_Update_Stored_Credential_flow
branch
from
79c1c43
to
c5a4d22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spreedly reference:
ECS-3532
Unit tests
Finished in 26.745895 seconds.
5912 tests, 79756 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
RuboCop
798 files inspected, no offenses detected